Wireshark-commits: [Wireshark-commits] master 83d0287: GPRSCDR: fix bitrates in EPCQoSInformation
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Mar 2018 10:45:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83d028792a430cd0232dc2eb06d611eab2b25ca7
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

83d0287 by Joakim Karlsson (oakimk@xxxxxxxxx):

    GPRSCDR: fix bitrates in EPCQoSInformation
    
    Changed type for the bitrate fields, from signed32 to unsigned32.
    This fixes the problem of getting "-1" values at G_MAXUINT32.
    
    TS 32.298 refers to TS 29.212 regarding bitrates, in TS 29.212 the
    corresponding AVPs are defined as Unsigned32.
    
    Change-Id: I6e0083bf034c7254ab48ca3c2c405cc20f5d6394
    Reviewed-on: https://code.wireshark.org/review/26585
    Petri-Dish: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  ca9976b   rsa: fix memleak and accept keys from certain PKCS#12 files
    adds  83d0287   GPRSCDR: fix bitrates in EPCQoSInformation


Summary of changes:
 epan/dissectors/asn1/gprscdr/gprscdr.cnf | 12 ++++++++++++
 epan/dissectors/packet-gprscdr.c         | 24 ++++++++++++------------
 2 files changed, 24 insertions(+), 12 deletions(-)