Wireshark-commits: [Wireshark-commits] master bd8df9e: Update to couchbase dissector for 'flexible
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 20 Mar 2018 12:15:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd8df9eb889650aacf5f02a806186a9f6cdbe0d4
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bd8df9e by Jim Walker (jim@xxxxxxxxxxxxx):

    Update to couchbase dissector for 'flexible framing extras' on errors
    
    The flexible framing extras can be on success and error packets, so
    move the call to dissect out of the success path.
    
    See:
    https://github.com/couchbase/kv_engine/blob/master/docs/BinaryProtocol.md#response-header-with-flexible-framing-extras
    
    Change-Id: I6fdadf4a90bd1e9c2b1e6e37793cc7a105fad3a6
    Reviewed-on: https://code.wireshark.org/review/26566
    Reviewed-by: Dave Rigby <daver@xxxxxxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Sergey Avseyev <sergey.avseyev@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  c75d497   X2AP: include packet-x2ap.h
    adds  bd8df9e   Update to couchbase dissector for 'flexible framing extras' on errors


Summary of changes:
 epan/dissectors/packet-couchbase.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)