Wireshark-commits: [Wireshark-commits] master-2.2 9cf1586: Don't register the link-layer 802.11 dis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 20 Mar 2018 06:56:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9cf158667301a3009509ed7c2aeef9b97006ffbf
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

9cf1586 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't register the link-layer 802.11 dissector in the gre.proto table.
    
    That dissector expects to be handed an 802.11 pseudoheader; the GRE
    dissector passes no data to subdissectors registered in the gre.proto
    table, which the 802.11 dissector will treat as an "FCS presence
    unknown" indication, even though it's known to be absent.
    
    Use the no-FCS 802.11 frame dissector instead.
    
    Bug: 14544
    Change-Id: I6515901dc3674eb36ec768fa4f9a7a4040a78365
    Reviewed-on: https://code.wireshark.org/review/26560
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 6401440932006465004650d3ac3722670174d0ac)
    Reviewed-on: https://code.wireshark.org/review/26562
    

Actions performed:

    from  3dceb21   [Automatic update for 2018-03-18]
    adds  9cf1586   Don't register the link-layer 802.11 dissector in the gre.proto table.


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 48 +++++++++++++++++++-------------------
 1 file changed, 24 insertions(+), 24 deletions(-)