Wireshark-commits: [Wireshark-commits] master-2.4 a08c857: Qt: allow keyboard navigation in Unsaved
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 18 Mar 2018 14:19:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a08c857c18c0f85a364d91b662d1cca272a12e5c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

a08c857 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: allow keyboard navigation in Unsaved packets dialog
    
    Currently the "Continue without Saving" button is visually highlighted
    in the "Unsaved packets..." dialog, but pressing Enter triggers "Save"
    instead. Even after changing button focus with arrow or tab keys,
    pressing Enter will not confirm the action (but Spacebar does).
    Restore the expected behavior for Linux and Windows, but preserve the
    fix for macOS since (for which this was originally added).
    
    Bug: 14531
    Change-Id: Ic20fc5809b55949f6fd960bcb32618a4fa7fd1e9
    Fixes: v2.3.0rc0-2672-gb0335359e5 ("Qt: Give discard button focus (but not as default)")
    Reviewed-on: https://code.wireshark.org/review/26511
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 56425fce7c16abb4138daf2e82ca5158d187fb4c)
    Reviewed-on: https://code.wireshark.org/review/26534
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  a81124d   [Automatic update for 2018-03-18]
    adds  a08c857   Qt: allow keyboard navigation in Unsaved packets dialog


Summary of changes:
 ui/qt/capture_file_dialog.cpp | 2 ++
 ui/qt/main_window.cpp         | 2 ++
 2 files changed, 4 insertions(+)