Wireshark · Wireshark-commits: [Wireshark-commits] master c1b7c8f: Qt: ensure field is visible on selection from bytes view

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1b7c8f9d2d1e5c6177062acc589800e2b1237e9
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c1b7c8f by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: ensure field is visible on selection from bytes view
    
    Ensure that a selected field (via selectedFieldChanged) becomes visible
    in the packet details view when selected from the bytes view (or when
    found via a search).
    
    As making a field always visible seems a desirable feature (and in the
    interest of simplifying preferences), enable this by default using the
    smarter EnsureVisible hint.
    
    Remove the associated preferences and mark them GTK+ only.
    
    Change-Id: I05a918c1e09135c0b4e10f04024bff092756e55c
    Fixes: v2.5.0rc0-2383-g6b2764a41e ("ProtoTree behavior fixes.")
    Reviewed-on: https://code.wireshark.org/review/26509
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  401e335   tap-tcp-stream: fix indentation.
    adds  c1b7c8f   Qt: ensure field is visible on selection from bytes view


Summary of changes:
 epan/prefs.h                            |  4 +--
 ui/qt/main_window_preferences_frame.cpp | 19 --------------
 ui/qt/main_window_preferences_frame.h   |  2 --
 ui/qt/main_window_preferences_frame.ui  | 44 ---------------------------------
 ui/qt/proto_tree.cpp                    | 13 ++++------
 5 files changed, 7 insertions(+), 75 deletions(-)