Wireshark · Wireshark-commits: [Wireshark-commits] master de9a4ff: CoAP: Refactor code, option and payload dissection

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=de9a4ff91f7172543fe16af999abd46e5a263cb8
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

de9a4ff by Mališa Vučinić (malishav@xxxxxxxxx):

    CoAP: Refactor code, option and payload dissection
    
    OSCORE plaintext contains CoAP code, some CoAP options and CoAP payload.
    To avoid code duplication, CoAP dissection of these fields used by
    OSCORE is generalized and exported in packet-coap.h. Exported functions
    and their subroutines now operate explicitly on local variables. This
    allows OSCORE dissector to pass its header fields.
    
    Use of "offset_end" instead of "coap_length" to denote the end of
    message.
    
    Bug: 14417
    Change-Id: If51b0d585ab29d46c1c550fbf264fd3765ed4c32
    Reviewed-on: https://code.wireshark.org/review/25482
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  830ea57   CoAP: Hooks to OSCORE
    adds  de9a4ff   CoAP: Refactor code, option and payload dissection


Summary of changes:
 epan/dissectors/packet-coap.c | 583 ++++++++++++------------------------------
 epan/dissectors/packet-coap.h | 346 +++++++++++++++++++++++++
 2 files changed, 514 insertions(+), 415 deletions(-)