Wireshark · Wireshark-commits: [Wireshark-commits] master bbe5fc1: Epan+Qt: Invalidate cached column strings.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bbe5fc102821cc3fa9e661078311f681501025ef
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bbe5fc1 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Epan+Qt: Invalidate cached column strings.
    
    Add col_data_changed, which checks to see if we have updated column
    info. Add col_append_frame_number, which adds a frame number and sets
    col_data_changed. Call col_append_frame_number instead of
    col_append_fstr from some dissectors.
    
    Add PacketListRecord::invalidateAllRecords, which invalidates any cached
    record data. Add PacketListModel::invalidateAllColumnStrings which calls
    invalidateAllRecords and signals that our data has changed. Call
    invalidateAllColumnStrings when we have new name resolution or column
    information.
    
    Bug: 11414
    Bug: 11468
    Change-Id: I2671594a722f4f9436fe1df84d43489a148e0cee
    Reviewed-on: https://code.wireshark.org/review/26373
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  03af555   ssl-utils: fix compilation if not HAVE_LIBGCRYPT_AEAD.
    adds  bbe5fc1   Epan+Qt: Invalidate cached column strings.


Summary of changes:
 debian/libwireshark0.symbols        |  5 +++++
 epan/column-utils.c                 | 16 ++++++++++++++++
 epan/column-utils.h                 | 17 +++++++++++++++++
 epan/dissectors/packet-bthci_acl.c  |  6 +++---
 epan/dissectors/packet-btl2cap.c    |  2 +-
 epan/dissectors/packet-icmp.c       |  4 ++--
 epan/dissectors/packet-icmpv6.c     |  4 ++--
 epan/dissectors/packet-ip.c         |  2 +-
 epan/dissectors/packet-iso15765.c   |  2 +-
 epan/dissectors/packet-ltp.c        |  2 +-
 epan/dissectors/packet-reload.c     |  2 +-
 ui/qt/models/packet_list_model.cpp  |  7 +++++++
 ui/qt/models/packet_list_model.h    |  7 +++++++
 ui/qt/models/packet_list_record.cpp |  2 +-
 ui/qt/models/packet_list_record.h   |  1 +
 ui/qt/packet_list.cpp               | 10 ++++++----
 ui/qt/wireshark_application.cpp     | 12 +++++++-----
 ui/qt/wireshark_application.h       |  5 +++--
 18 files changed, 82 insertions(+), 24 deletions(-)