Wireshark-commits: [Wireshark-commits] master ab40224: (D)TLS: restrict ssl.ignore_ssl_mac_failed p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Mar 2018 06:01:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ab40224aca3c1aaeb1827ec444cd82ca53fc7a66
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ab40224 by Peter Wu (peter@xxxxxxxxxxxxx):

    (D)TLS: restrict ssl.ignore_ssl_mac_failed preference to ssl
    
    In preparation for TLS 1.3 early data trial decryption, give the caller
    of "ssl_decrypt_record" control over skipping integrity check failures.
    As a side-effect, this will avoid a ssl preference from affecting DTLS.
    If desired, a DTLS-specific preference can be added at a later point.
    
    Change-Id: Ib84a127b4dab524902edeb2d335d069db0304ded
    Ping-Bug: 12779
    Reviewed-on: https://code.wireshark.org/review/26473
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  b9b5c6b   f5ethtrailler: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    adds  ab40224   (D)TLS: restrict ssl.ignore_ssl_mac_failed preference to ssl


Summary of changes:
 epan/dissectors/packet-dtls.c      |  2 +-
 epan/dissectors/packet-ssl-utils.c | 12 +++++++-----
 epan/dissectors/packet-ssl-utils.h |  2 ++
 epan/dissectors/packet-ssl.c       |  5 ++---
 epan/dissectors/packet-ssl.h       |  2 --
 5 files changed, 12 insertions(+), 11 deletions(-)