Wireshark-commits: [Wireshark-commits] master 0ebcd27: Trust CMake's Visual C++ version detection.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Mar 2018 21:50:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ebcd273772ed1805a0d9f558827df152e392d30
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0ebcd27 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Trust CMake's Visual C++ version detection.
    
    We can be reasonably certain that CMake sets CMAKE_C_COMPILER_ID,
    MSVC12 and MSVC14 correctly. If we add a compiler flag based on those
    variables don't bother passing it through check_c_compiler_flag or
    check_cxx_compiler_flag. This speeds up CMake here quite a bit.
    
    Change-Id: I3a681a8a9287b33353030fd37303aa32f04b79a9
    Reviewed-on: https://code.wireshark.org/review/26475
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  07647c2   NAS-5GS: Start updating to version 0.4.0
    adds  0ebcd27   Trust CMake's Visual C++ version detection.


Summary of changes:
 CMakeLists.txt | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)