Wireshark-commits: [Wireshark-commits] master 0874b8b: Remove popcount in favor of ws_count_ones.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Mar 2018 17:18:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0874b8bac6ca89f1d91d30d66d54f425e4e7c81e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0874b8b by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Remove popcount in favor of ws_count_ones.
    
    Remove our popcount implementation in favor of ws_count_ones, which
    is our other popcount implementation. This required updating and
    running process-x11-xcb.pl.
    
    Change-Id: I8634c55242113b338c5b0173837c35f98b148b4f
    Reviewed-on: https://code.wireshark.org/review/26454
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a2cbec7   nordic_ble: Fix delta time start-to-start calculation
    adds  0874b8b   Remove popcount in favor of ws_count_ones.


Summary of changes:
 ConfigureChecks.cmake                          |  1 -
 cmakeconfig.h.in                               |  3 --
 configure.ac                                   |  1 -
 debian/libwsutil0.symbols                      |  1 -
 epan/dissectors/packet-x11.c                   |  4 +-
 epan/dissectors/x11-extension-implementation.h | 54 +++++++++++++-------------
 epan/dissectors/x11-glx-render-enum.h          |  3 +-
 tools/process-x11-fields.pl                    | 14 +------
 tools/process-x11-xcb.pl                       | 16 +-------
 wsutil/CMakeLists.txt                          |  4 --
 wsutil/Makefile.am                             |  2 -
 wsutil/popcount.c                              | 30 --------------
 wsutil/popcount.h                              | 18 ---------
 13 files changed, 33 insertions(+), 118 deletions(-)
 delete mode 100644 wsutil/popcount.c
 delete mode 100644 wsutil/popcount.h