Wireshark-commits: [Wireshark-commits] master e7cf995: Squelch some casting-away-const warnings.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 08 Mar 2018 03:46:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7cf995b1e0a9b434782adf0e2ee40bfb721aac2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e7cf995 by Guy Harris (guy@xxxxxxxxxxxx):

    Squelch some casting-away-const warnings.
    
    Code *outside* this file isn't allowed to free or overwrite the
    structure members in question; code *inside* this file only does so when
    it's appropriate, so we just cast away the warnings.
    
    Use free_string_like_preference() in one place where the code was
    duplicated; add a pref_set_string_like_pref_value() routine to
    encapsulate the freeing.
    
    Remove some unnecessary casts.
    
    Change-Id: Ifc30a919cbd331367f5932ad23c3a1ed7cd4579f
    Reviewed-on: https://code.wireshark.org/review/26352
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e5cc633   Constify an argument that doesn't need to be non-const.
    adds  e7cf995   Squelch some casting-away-const warnings.


Summary of changes:
 epan/prefs.c | 32 ++++++++++++++++++++++----------
 1 file changed, 22 insertions(+), 10 deletions(-)