Wireshark-commits: [Wireshark-commits] master-2.2 dac48f1: LWAPP: define a recursion depth limit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 07 Mar 2018 22:04:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dac48f148538c706c446e5105d84ebcb54587528
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

dac48f1 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    LWAPP: define a recursion depth limit
    
    Altough the dissection consumes a few ytes each time it is called,
    it can trigger a stack overflow for big packets.
    Let's limmit the number of allowed encapsulation for a given packet.
    
    Bug: 14467
    Change-Id: I73e82e01810b63a4f603907e69b20f3715a4ad55
    Reviewed-on: https://code.wireshark.org/review/26338
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1592587e6f9fd8c8aa8fc7f67989690d0c6882c4)
    Reviewed-on: https://code.wireshark.org/review/26344
    

Actions performed:

    from  5b02289   multipart: use packet scope memory to avoid leaking in case an exception is triggered by subdissectors
    adds  dac48f1   LWAPP: define a recursion depth limit


Summary of changes:
 epan/dissectors/packet-lwapp.c | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)