Wireshark-commits: [Wireshark-commits] master b434e0a: VLAN: define a recursion depth limit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 06 Mar 2018 07:21:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b434e0a03be45ed796af7271972672a0b43cffa8
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b434e0a by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    VLAN: define a recursion depth limit
    
    Altough the dissection consumes 4 bytes each time it is called, it can
    trigger a stack overflow for big packets. Let's limmit the number of
    allowed VLAN tags for a given packet.
    
    Bug: 14469
    Change-Id: Ieb6834ab3350dc7e8c301e6479577855a253897e
    Reviewed-on: https://code.wireshark.org/review/26270
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  c39dbd6   extcap: add g_free to extcap_free_toolbar_value (found by clang).
    adds  b434e0a   VLAN: define a recursion depth limit


Summary of changes:
 epan/dissectors/packet-vlan.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)