Wireshark-commits: [Wireshark-commits] master-2.4 f920d7a: Add support for new peekremote features.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 04 Mar 2018 04:02:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f920d7ae53495032469b1ab74f962dac746ee241
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

f920d7a by Nicolas Darchis (ndarchis@xxxxxxxxx):

    Add support for new peekremote features.
    
    Enhanced peekremote dissector to take into account the new extended
    flags written by Cisco APs in sniffer mode after WLC version 8.5.
    
    Support for 80mhz channel flag (bit 9), short preamble (bit 8), amount
    of spatial streams (bit 14-16)
    dot11_ht_vht_flags=0x00000551 <--short preamble encoded to 10th bit of
    dot11_ht_vht_flags.
    dot11_ht_vht_flags=0x00008bc8 <--80MHz info encoded to 9th bit of
    dot11_ht_vht_flags.
    
    The spatial streams information is already encoded to 16:15:14 bits of
    dot11_ht_vht_flags. The following are the bit pattern representation,
    000 - 1 spatial stream
    001 - 2 spatial streams
    010 - 3 spatial streams
    
    Bug: 14452
    Change-Id: If0539e356b32a791901d213a653f7a98521667ee
    Reviewed-on: https://code.wireshark.org/review/26178
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b580bdb9ddd5459bcdac95948ec41eae55be734f)
    Reviewed-on: https://code.wireshark.org/review/26252
    

Actions performed:

    from  37dc541   Don't crash in manually_resolve_cleanup() if there's nothing to clean up.
    adds  f920d7a   Add support for new peekremote features.


Summary of changes:
 epan/dissectors/packet-peekremote.c | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)