Wireshark-commits: [Wireshark-commits] master f529ab5: Remove the endpoint "Map" feature.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 02 Mar 2018 21:59:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f529ab5d0a27173ed68aa017a638b36b3dcf585f
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f529ab5 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Remove the endpoint "Map" feature.
    
    Remove the endpoint map and its button from the Qt and GTK+ UIs. It
    depends on GeoIP Legacy for coordinate information and those databases
    are being deprecated in favor of MaxMind DB. We *could* upgrade the code
    to use mmdbresolve, but according to
    https://dev.maxmind.com/geoip/geoip2/geolite2/ they're also going to
    remove coordinate information from GeoLite2:
    
    "In addition, in 2019, latitude and longitude coordinates in the
     GeoLite2 databases will be removed.* Latitude and longitude coordinates
     will continue to be provided in GeoIP2 databases. Please check back for
     updates."
    
    Change-Id: I43e1593d282a0f1aae897b1f4724117d1496b21e
    Reviewed-on: https://code.wireshark.org/review/26229
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  84c7246   extcap: Make settings dialog modal
    adds  f529ab5   Remove the endpoint "Map" feature.


Summary of changes:
 CMakeLists.txt                                     |  10 -
 Makefile.am                                        |   3 +-
 debian/control                                     |   2 +-
 debian/patches/02_use_packaged_openlayers_js.patch |  17 --
 debian/patches/series                              |   1 -
 docbook/release-notes.asciidoc                     |   1 +
 docbook/wsug_src/WSUG_chapter_statistics.asciidoc  |   3 +-
 ipmap.html                                         | 106 ----------
 packaging/macosx/Scripts/wireshark-postinstall.sh  |   7 -
 packaging/nsis/uninstall.nsi                       |   1 -
 packaging/nsis/wireshark.nsi                       |   1 -
 packaging/wix/ComponentGroups.wxi                  |   3 -
 ui/gtk/hostlist_table.c                            | 101 ---------
 ui/qt/endpoint_dialog.cpp                          |  41 ----
 ui/qt/endpoint_dialog.h                            |   7 -
 ui/traffic_table_ui.c                              | 233 ---------------------
 ui/traffic_table_ui.h                              |  13 --
 17 files changed, 4 insertions(+), 546 deletions(-)
 delete mode 100644 debian/patches/02_use_packaged_openlayers_js.patch
 delete mode 100644 ipmap.html