Wireshark-commits: [Wireshark-commits] master e808832: One strstr() call suffices.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 02 Mar 2018 09:00:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8088329ec35ad7c178695594996e6ea102ba7ea
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e808832 by Guy Harris (guy@xxxxxxxxxxxx):

    One strstr() call suffices.
    
    If we've found "interleaved=" in the buffer *and*, if so, know where
    we've found it, we don't need to find it again; we can just use the
    result of the first strstr() call.
    
    That should also keep Visual Studio Code Analyzer from bogusly saying
    "hey, we might not have found it, maybe we're handing a bad pointer to
    sscanf()".
    
    Change-Id: I9d8f5c0b38038a3f05b8e5343f965f1676105875
    Reviewed-on: https://code.wireshark.org/review/26219
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  24b5a55   quic: Make sure that we still build when certain libraries not found.
    adds  e808832   One strstr() call suffices.


Summary of changes:
 epan/dissectors/packet-rtsp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)