Wireshark · Wireshark-commits: [Wireshark-commits] master-2.2 c9ace2f: Don't handle various "command to send" values in the default

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9ace2f0d57a9c649de5a0e3ccab6e95fc7e5ca2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c9ace2f by Guy Harris (guy@xxxxxxxxxxxx):

    Don't handle various "command to send" values in the default case.
    
    The default case ignores the high-order bit, which is set in all the
    values for "command to send", so they will never be matched.  The values
    moved out of the default case, if their upper bit is clear, either don't
    correspond to any command in T.30 or correspond to an initial
    identification command, which never has the upper bit set, so there's no
    risk of misidentification by processing all of the "command to send"
    values outside the default case.
    
    Thanks and a tip of the Hatlo hat to Visual Studio Code Analysis for
    catching this one.
    
    Change-Id: I6192b0c5a6dcfd31b9fd757be736a311a9d089e6
    Reviewed-on: https://code.wireshark.org/review/26198
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit efd8beff4f9a6b39a7b43b18716bceb4a9f07e1f)
    Reviewed-on: https://code.wireshark.org/review/26200
    

Actions performed:

    from  261c345   Fix StringCchPrintf() calls.
    adds  c9ace2f   Don't handle various "command to send" values in the default case.


Summary of changes:
 epan/dissectors/packet-t30.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)