Wireshark-commits: [Wireshark-commits] master ea0b580: Fix a check.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Feb 2018 20:08:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea0b580b978834a4ce0ea8c29cf02da1a3512c0a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ea0b580 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix a check.
    
    Presumably the intent is to check for unsigned integer and signed
    integer types, not to check twice for unsigned integer types.
    
    Thanks and a tip of the Hatlo hat to Visual Studio Code Analyzer for
    finding this.
    
    Change-Id: Ie8e4d231af929ee8e626c5c9258c3356d5209f4f
    Reviewed-on: https://code.wireshark.org/review/26187
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  03474c1   Redo the way we choose N/S/E/W.
    adds  ea0b580   Fix a check.


Summary of changes:
 epan/proto.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)