Wireshark-commits: [Wireshark-commits] master-2.2 2f5159a: Include <config.h> so UNICODE is defined
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Feb 2018 17:32:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f5159a23cf332a3902382880e200ae2aeda1231
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2f5159a by Guy Harris (guy@xxxxxxxxxxxx):

    Include <config.h> so UNICODE is defined.
    
    All other files should do so; this file should, so that we're using the
    Unicode versions of Windows APIs (especially given that other files that
    include wsutil/unicode-utils.h will be doing so and expecting UTF-16
    strings from utf_8to16_snprintf()).
    
    Change-Id: I7eccf580ab0dc504aa78b345e36e2fcda818a7c5
    Reviewed-on: https://code.wireshark.org/review/26170
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 9f2dff98f6526412e8065a8c9ade811dcb1974fe)
    Reviewed-on: https://code.wireshark.org/review/26180
    (cherry picked from commit 9a84ec49ca0bc199fb22410705b72f93f28bb9b8)
    Reviewed-on: https://code.wireshark.org/review/26181
    

Actions performed:

    from  0290a62   adb: fix buffer overflow while processing message payload
    adds  2f5159a   Include <config.h> so UNICODE is defined.


Summary of changes:
 wsutil/unicode-utils.c | 2 ++
 1 file changed, 2 insertions(+)