Wireshark-commits: [Wireshark-commits] master 1653ea5: adb: fix buffer overflow while processing me
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Feb 2018 09:11:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1653ea5fcedf369452c0cf41e09e57666525615c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1653ea5 by Peter Wu (peter@xxxxxxxxxxxxx):

    adb: fix buffer overflow while processing message payload
    
    Fix a heap buffer overflow (write) when the message header length is
    smaller than the actual message payload length. Add expert info to
    detect this since it can also occur when the header is wrongly matched
    with a data fragment (this dissector issue is not fixed here).
    
    Bug: 14460
    Change-Id: I12f411a5189809a0931dfcdb2797997d5e19efc1
    Reviewed-on: https://code.wireshark.org/review/26104
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ba0f4b9   adb: fix Malformed packet while parsing CONNECT command
    adds  1653ea5   adb: fix buffer overflow while processing message payload


Summary of changes:
 epan/dissectors/packet-adb.c | 34 +++++++++++++++++++++++++++-------
 1 file changed, 27 insertions(+), 7 deletions(-)