Wireshark-commits: [Wireshark-commits] master 74641da: adb: fix decoding of local-id argument of Wr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Feb 2018 14:06:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74641daaae226adf2b248ada91697cf3e244ec74
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

74641da by Peter Wu (peter@xxxxxxxxxxxxx):

    adb: fix decoding of local-id argument of Write
    
    Tested with adb-oreo.pcapng from bug 14460, packet 110 should show
    "Write(10, 1)" instead of "Write(0, 1)" per spec:
    https://android.googlesource.com/platform/system/core/+/android-8.1.0_r7/adb/protocol.txt#146
    
    Change-Id: Ifa9fb43979237b7a28586e1d41859b455d3cf5ab
    Reviewed-on: https://code.wireshark.org/review/26105
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxxxxxx>
    

Actions performed:

    from  ef0e841   [GTPv2] Add new IE UP Function Selection Indication Flags
    adds  74641da   adb: fix decoding of local-id argument of Write


Summary of changes:
 epan/dissectors/packet-adb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)