Wireshark-commits: [Wireshark-commits] master 20d7254: Bootp: Adding some DHCP options
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Feb 2018 08:04:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20d7254cb6b30324b76355c76c1852e802edd647
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

20d7254 by Uli Heilmeier (uh@xxxxxxxxxxxx):

    Bootp: Adding some DHCP options
    
    Used Ref:
    * https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml
    * RFC 6225: Dynamic Host Configuration Protocol Options for Coordinate-Based Location Configuration Information
    * RFC 6704: Forcerenew Nonce Authentication
    * RFC 6731: Improved Recursive DNS Server Selection for Multi-Interfaced Nodes
    * RFC 6926: DHCPv4 Bulk Leasequery
    * RFC 7291: DHCP Options for the Port Control Protocol (PCP)
    * RFC 7618: Dynamic Allocation of Shared IPv4 Addresses
    
    Change-Id: Ied53f88b2018f1d054a8ba22f1a1d6f7c075621a
    Reviewed-on: https://code.wireshark.org/review/26063
    Reviewed-by: Craig Jackson <cejackson51@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ba4ff84   TDS: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    adds  20d7254   Bootp: Adding some DHCP options


Summary of changes:
 epan/dissectors/packet-bootp.c | 339 +++++++++++++++++++++++++++++++++++++++--
 1 file changed, 324 insertions(+), 15 deletions(-)