Wireshark-commits: [Wireshark-commits] master-2.4 5057322: Fix stripping of binaries.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Feb 2018 04:40:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=505732200fb86c2177d24e571814495649902904
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

5057322 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix stripping of binaries.
    
    Instead of using the never-defined $binpath (undefined going back to at
    least Wireshark 1.0.0 - is it a leftover from the Inkscape version?),
    use $bundle_binary_list, to strip all the executables with strip -ur.
    
    (Not that we want to strip anything - we don't even want the debugging
    symbols stripped! - but for cleanliness.)
    
    Change-Id: I9c3520ffb418bf9dc206d3ccb55d347c208f3be2
    Reviewed-on: https://code.wireshark.org/review/26033
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 316b858d28092bb1c55ff50cfe68ae51f34425de)
    Reviewed-on: https://code.wireshark.org/review/26034
    

Actions performed:

    from  974bfad   Qt: Another filter expression toolbar layout attempt.
    adds  5057322   Fix stripping of binaries.


Summary of changes:
 packaging/macosx/osx-app.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)