Wireshark-commits: [Wireshark-commits] master-2.4 cb11168: IPMI: Disable bus command dissection.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Feb 2018 22:28:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb11168ab024ac1da21d3b4cbed6c58c4992d626
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

cb11168 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    IPMI: Disable bus command dissection.
    
    This dissector has had multiple, severe issues over the years. Disable
    bus command dissection by default. Add a warning about re-enabling it.
    
    Change-Id: I9f71fafe2961f349825e6eda1f351025e00be182
    Reviewed-on: https://code.wireshark.org/review/26009
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  407b238   Check for dependencies in all subdirectories of $pkglib and $pkgexec.
    adds  cb11168   IPMI: Disable bus command dissection.


Summary of changes:
 epan/dissectors/packet-ipmi.c | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)