Wireshark · Wireshark-commits: [Wireshark-commits] master 397d32b: dcerpc_decode_as_change() doesn't need to change the old binding

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=397d32b863b640ccded140acd6eec94da367264b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

397d32b by Guy Harris (guy@xxxxxxxxxxxx):

    dcerpc_decode_as_change() doesn't need to change the old binding.
    
    The search doesn't use the fields we change (if it did, we probably
    shouldn't change them, as the old binding might not be found), so don't
    change them.
    
    Instead, when we allocate a *new* binding structure, put the new values
    into *that* structure.
    
    Squelches a "casting away constness" warning.
    
    Change-Id: I6dbd1a4cbc2415373f4926f443f9756c8113c0be
    Reviewed-on: https://code.wireshark.org/review/25841
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  86f2ff6   Yet Another Narrowing Warning to suppress.
    adds  397d32b   dcerpc_decode_as_change() doesn't need to change the old binding.


Summary of changes:
 epan/dissectors/packet-dcerpc.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)