Wireshark-commits: [Wireshark-commits] master 8b9dfba: The CRC8 routines don't modify the buffer; m
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 Feb 2018 19:30:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b9dfbaba9f10cffd41b0cca1446a7a6c5b6eb90
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8b9dfba by Guy Harris (guy@xxxxxxxxxxxx):

    The CRC8 routines don't modify the buffer; make the pointers to it const.
    
    This lets us get rid of some casts that provoke "drops const qualifier"
    warnings.
    
    Change-Id: Ia7e0863bd97bc20dbbb810e13778ec78d0cf3c91
    Reviewed-on: https://code.wireshark.org/review/25837
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  dc8bd7c   Fix argument list in comment.
    adds  8b9dfba   The CRC8 routines don't modify the buffer; make the pointers to it const.


Summary of changes:
 epan/dissectors/packet-cipsafety.c | 22 +++++++++++-----------
 wsutil/crc8.c                      |  8 ++++----
 wsutil/crc8.h                      |  6 +++---
 3 files changed, 18 insertions(+), 18 deletions(-)