Wireshark-commits: [Wireshark-commits] master 5bf8da8: Fix casts.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 Feb 2018 18:41:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5bf8da8a4cd5381d1d206ce7074690dba463dba0
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5bf8da8 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix casts.
    
    A gconstpointer is a "pointer to const void", so it should be cast to
    "pointer to const XXX".  A "pointer to const pointer to plugin" is a
    "plugin *const *".
    
    C's declaration syntax is not one of its strong points.  There's a
    reason why the cdecl program, and the Web site that uses it,
    http://cdecl.org, exists (as the tag line says, "C gibberish <->
    English"), and why I used it to make sure I got this working.
    
    Change-Id: Ia29bb25d17a1255a06b4ace542643c4b494d4977
    Reviewed-on: https://code.wireshark.org/review/25835
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f0393a5   wisun: Add EDFE support
    adds  5bf8da8   Fix casts.


Summary of changes:
 wsutil/plugins.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)