Wireshark-commits: [Wireshark-commits] master 4a69d10: Squelch redundant declaration warnings.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Feb 2018 22:40:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a69d10920c47fbbb5522adbb478cfeb8f6785dc
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a69d10 by Guy Harris (guy@xxxxxxxxxxxx):

    Squelch redundant declaration warnings.
    
    Have the text-to-pcap scanners define a routine that the main code
    calls, which both allocates and destroys the scanner.  Don't declare the
    Lex-generated routines in a header file we create, declare that routine,
    instead.
    
    Change-Id: Icad6a83db1a0dea8ac390315af72383fc99f8513
    Reviewed-on: https://code.wireshark.org/review/25822
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c881ee3   [PFCP] Added dissect function for User Plane Inactivity Timer IE
    adds  4a69d10   Squelch redundant declaration warnings.


Summary of changes:
 text2pcap-scanner.l      | 10 ++++++++++
 text2pcap.c              |  3 +--
 text2pcap.h              |  4 +---
 ui/text_import.c         | 17 ++---------------
 ui/text_import_scanner.h |  2 +-
 ui/text_import_scanner.l | 17 +++++++++++++++++
 6 files changed, 32 insertions(+), 21 deletions(-)