Wireshark-commits: [Wireshark-commits] master 72b57ac: Use DIAG_OFF_FLEX/DIAG_ON_FLEX more consiste
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Feb 2018 19:54:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=72b57ac4ef653c1909e4c1d1daf40de2357b77e8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

72b57ac by Guy Harris (guy@xxxxxxxxxxxx):

    Use DIAG_OFF_FLEX/DIAG_ON_FLEX more consistently.
    
    Add warning C4267 (size_t to int conversion) with MSVC to DIAG_OFF_FLEX.
    
    Addd -Wshorten-64-to-32 with Clang and GCC to DIAG_OFF_FLEX.
    
    Don't explicitly use #pragma to turn off warnings; use DIAG_OFF_FLEX for
    all of them.
    
    If we use DIAG_OFF_FLEX, use DIAG_ON_FLEX, even if we have no section of
    entirely included code at the end.
    
    Change-Id: Ibfd44e8954704e9a8bcb1bd8e54f31d28357fffb
    Reviewed-on: https://code.wireshark.org/review/25817
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0967192   mac-lte: fix memory leak of mac_lte_msg3_cr_hash
    adds  72b57ac   Use DIAG_OFF_FLEX/DIAG_ON_FLEX more consistently.


Summary of changes:
 epan/diam_dict.l                          | 21 ++++++---------
 epan/dtd_parse.l                          | 16 +++++------
 epan/uat_load.l                           |  6 -----
 plugins/epan/wimaxasncp/wimaxasncp_dict.l | 21 ++++++---------
 text2pcap-scanner.l                       |  7 +++++
 ui/text_import_scanner.l                  |  7 +++++
 wiretap/ascend_scanner.l                  | 12 ++++++++-
 wiretap/k12text.l                         | 10 +++++--
 ws_diag_control.h                         | 44 +++++++++++++++++++++++++++----
 9 files changed, 96 insertions(+), 48 deletions(-)