Wireshark-commits: [Wireshark-commits] master 8bc1c6e: Add DIAG_OFF_FLEX and DIAG_ON_FLEX for use i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Feb 2018 10:35:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8bc1c6e3e8c0a84ee656d1e1d68530fc9bf2e35d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8bc1c6e by Guy Harris (guy@xxxxxxxxxxxx):

    Add DIAG_OFF_FLEX and DIAG_ON_FLEX for use in Flex scanners.
    
    DIAG_OFF_FLEX turns off all warnings that we want to disable for
    Flex-generated code due to some versions of Flex generating code that
    triggers those warnings.
    
    DIAG_ON_FLEX restores those warnings, so we do the checks for code that
    *we* wrote.
    
    Use them in .l files.
    
    Change-Id: I613a20309a30cd4c61111a1edbe27a5d05fcbf59
    Reviewed-on: https://code.wireshark.org/review/25815
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b6bec7d   Treat most Lex-generated and all Lemon-generated files as clean.
    adds  8bc1c6e   Add DIAG_OFF_FLEX and DIAG_ON_FLEX for use in Flex scanners.


Summary of changes:
 epan/dfilter/scanner.l          | 16 ++++++++--------
 epan/dtd_preparse.l             | 16 ++++++++--------
 epan/radius_dict.l              | 16 ++++++++--------
 epan/uat_load.l                 | 16 ++++++++--------
 plugins/epan/mate/mate_parser.l | 16 ++++++++--------
 text2pcap-scanner.l             | 11 ++++-------
 ui/text_import_scanner.l        |  9 ++++-----
 ws_diag_control.h               | 30 +++++++++++++++++++++++++++++-
 8 files changed, 77 insertions(+), 53 deletions(-)