Wireshark-commits: [Wireshark-commits] master 010c73d: Disable warning C4267 in generated files.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Feb 2018 05:31:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=010c73daa65847035cab3f64367300b6cba2d038
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

010c73d by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Disable warning C4267 in generated files.
    
    Disable warning C4267 in Visual C++ in order to squelch the following
    warnings:
    
       125>dtd_parse.c(1699): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\epan\epan.vcxproj]
       125>diam_dict.c(2348): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\epan\epan.vcxproj]
       125>C:/buildbot/builders/windows-x86-64-petri-dish/windows-x86-64-petri-dish/build/cmbuild/epan/uat_load.c(1476): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\epan\epan.vcxproj]
       130>wimaxasncp_dict.c(2103): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\plugins\epan\wimaxasncp\wimaxasncp.vcxproj]
    
    Change-Id: Ie29ae096e5a8b5037abaf3f2aa97754260f4cace
    Reviewed-on: https://code.wireshark.org/review/25800
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6325ceb   DCT2000: read new LTE MAC outheader values
    adds  010c73d   Disable warning C4267 in generated files.


Summary of changes:
 epan/diam_dict.l                          | 6 ++++++
 epan/dtd_parse.l                          | 6 ++++++
 epan/uat_load.l                           | 6 ++++++
 plugins/epan/wimaxasncp/wimaxasncp_dict.l | 6 ++++++
 4 files changed, 24 insertions(+)