Wireshark-commits: [Wireshark-commits] master 9198448: Qt: fix crash in packet dialog on changing s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Feb 2018 08:03:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9198448f9db7b77af8d19f8265d6785fb005dc58
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9198448 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix crash in packet dialog on changing selection
    
    "((capture_file_t *)cap_file_)->edt" is documented in cfile.h to cover
    the currently selected packet (in the packet list). But in the packet
    dialog, the packet selection is irrelevant and the data from a different
    dissection tree must be used.
    
    Change-Id: Ieaea3cf862d47540e7f6b6c84c1a2fa6945a877b
    Fixes: v2.5.0rc0-1532-g56a130a152 ("ByteViewText: Remove epan dependancy")
    Bug: 14246
    Reviewed-on: https://code.wireshark.org/review/25437
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  f0db412   Convert coloring rules dialog to use model.
    adds  9198448   Qt: fix crash in packet dialog on changing selection


Summary of changes:
 ui/qt/byte_view_tab.cpp | 37 +++++++++++++++++++++++++++++--------
 ui/qt/byte_view_tab.h   |  6 +++++-
 ui/qt/packet_dialog.cpp |  2 +-
 3 files changed, 35 insertions(+), 10 deletions(-)