Wireshark-commits: [Wireshark-commits] master feb8f6b: Make the DOCSIS dissector a built-in dissect
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Feb 2018 20:15:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=feb8f6b14d7e342db369656ab44c38546b0140bb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

feb8f6b by Guy Harris (guy@xxxxxxxxxxxx):

    Make the DOCSIS dissector a built-in dissector.
    
    Stuff that calls it is built in, and stuff it calls is built in, so
    there's not much point in having it be a plugin; we already have
    examples of plugin dissectors.
    
    Change-Id: I512e0fda62faedb5f03f476fbece2e267e1d644f
    Reviewed-on: https://code.wireshark.org/review/25775
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  048c437   Asciidoctor macro fixups.
    adds  feb8f6b   Make the DOCSIS dissector a built-in dissector.


Summary of changes:
 CMakeLists.txt                                     |  1 -
 configure.ac                                       |  1 -
 epan/dissectors/CMakeLists.txt                     |  5 ++
 epan/dissectors/Makefile.am                        |  5 ++
 .../dissectors/packet-docsis-macmgmt.c             |  2 +-
 .../dissectors/packet-docsis-tlv.c                 |  8 +-
 .../dissectors/packet-docsis-tlv.h                 |  0
 .../dissectors/packet-docsis-vendor.c              |  0
 .../docsis => epan/dissectors}/packet-docsis.c     |  4 +
 packaging/nsis/wireshark.nsi                       |  1 -
 packaging/wix/Plugins.wxi                          |  4 -
 plugins/Makefile.am                                |  1 -
 plugins/epan/docsis/AUTHORS                        |  3 -
 plugins/epan/docsis/CMakeLists.txt                 | 85 ----------------------
 plugins/epan/docsis/ChangeLog                      | 15 ----
 plugins/epan/docsis/Makefile.am                    | 71 ------------------
 plugins/epan/docsis/README                         | 52 -------------
 17 files changed, 19 insertions(+), 239 deletions(-)
 rename plugins/epan/docsis/packet-macmgmt.c => epan/dissectors/packet-docsis-macmgmt.c (99%)
 rename plugins/epan/docsis/packet-tlv.c => epan/dissectors/packet-docsis-tlv.c (99%)
 rename plugins/epan/docsis/packet-tlv.h => epan/dissectors/packet-docsis-tlv.h (100%)
 rename plugins/epan/docsis/packet-vendor.c => epan/dissectors/packet-docsis-vendor.c (100%)
 rename {plugins/epan/docsis => epan/dissectors}/packet-docsis.c (99%)
 delete mode 100644 plugins/epan/docsis/AUTHORS
 delete mode 100644 plugins/epan/docsis/CMakeLists.txt
 delete mode 100644 plugins/epan/docsis/ChangeLog
 delete mode 100644 plugins/epan/docsis/Makefile.am
 delete mode 100644 plugins/epan/docsis/README