Wireshark-commits: [Wireshark-commits] master d332507: Fix the "pointer to function that generates
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Feb 2018 18:06:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d332507ef2771f5c623a6768caadcabe6dd5583d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d332507 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the "pointer to function that generates a label" values.
    
    build_label_func is a pointer type, pointing to a function that can be
    used to generate a label for a "Decode As" entry.  There's no need to
    have pointers to those pointers; have register_decode_as_next_proto()
    take a build_label_func, not a build_label_func *, as its last argument,
    assign that value rather than dereferencing it, get rid of unnecessary
    casts, and fix the comment in epan/decode_as.h for that argument.
    
    Change-Id: Idc3cf18204c543a2191b122c8129b362562c0ecd
    Reviewed-on: https://code.wireshark.org/review/25773
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bb9e26e   ssl: Add session ticket lifetime units in seconds
    adds  d332507   Fix the "pointer to function that generates a label" values.


Summary of changes:
 epan/decode_as.c                    | 4 ++--
 epan/decode_as.h                    | 5 +++--
 epan/dissectors/packet-aruba-erm.c  | 2 +-
 epan/dissectors/packet-bthci_cmd.c  | 2 +-
 epan/dissectors/packet-enip.c       | 2 +-
 epan/dissectors/packet-flip.c       | 2 +-
 epan/dissectors/packet-i2c.c        | 2 +-
 epan/dissectors/packet-infiniband.c | 2 +-
 epan/dissectors/packet-moldudp.c    | 2 +-
 epan/dissectors/packet-moldudp64.c  | 2 +-
 epan/dissectors/packet-nfs.c        | 2 +-
 epan/dissectors/packet-pcli.c       | 2 +-
 epan/dissectors/packet-rtacser.c    | 2 +-
 epan/dissectors/packet-smp.c        | 2 +-
 14 files changed, 17 insertions(+), 16 deletions(-)