Wireshark-commits: [Wireshark-commits] master 2cf6517: NBAP: Fix and enhance SIB parsing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Feb 2018 06:17:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2cf6517ec088cadf60dec1f1c93b8575e4a4f40a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2cf6517 by Nick James (mookito@xxxxxxx):

    NBAP: Fix and enhance SIB parsing
    
    1. Parsing of complete-sib-short was wrong - did not consider the 8 bits of length in the begining
    2. Added re-assembly logic for SIBs segmented into first/subsequent/last payloads
    
    Change-Id: I2c4aab2cace795c3e47a22921a34efc4ee26a25f
    Reviewed-on: https://code.wireshark.org/review/25598
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  045c48e   html2text: Prefix lists with a bullet.
    adds  2cf6517   NBAP: Fix and enhance SIB parsing


Summary of changes:
 epan/dissectors/asn1/nbap/nbap.cnf               | 237 ++++++++--
 epan/dissectors/asn1/nbap/packet-nbap-template.c |  46 ++
 epan/dissectors/asn1/rrc/packet-rrc-template.c   |   2 -
 epan/dissectors/asn1/rrc/rrc.cnf                 |  19 +
 epan/dissectors/packet-nbap.c                    | 569 ++++++++++++++++-------
 epan/dissectors/packet-nbap.h                    |   2 +-
 epan/dissectors/packet-rrc.c                     | 484 ++++++++++---------
 epan/dissectors/packet-rrc.h                     |  19 +
 8 files changed, 925 insertions(+), 453 deletions(-)