Wireshark-commits: [Wireshark-commits] master-2.4 2e83207: RPC Netlogon: do not leak memory each ti
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Feb 2018 09:14:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e832078507d81e4897178af4091ad52ec0ceef3
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

2e83207 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    RPC Netlogon: do not leak memory each time a hash is generated
    
    Use copy_address_swallow() instead of copy_address().
    When inserting the key in the hash map, copy it in wmem file scope.
    
    Bug: 14407
    Change-Id: Ida524d314c943f480dd0e1bf44fd0ded01aafaeb
    Reviewed-on: https://code.wireshark.org/review/25731
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit d2016c6a1bb9a1688da684825cbda889d95238a6)
    Reviewed-on: https://code.wireshark.org/review/25746
    

Actions performed:

    from  29d920b   SIGCOMP: use correct message length
    adds  2e83207   RPC Netlogon: do not leak memory each time a hash is generated


Summary of changes:
 epan/dissectors/packet-dcerpc-netlogon.c | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)