Wireshark-commits: [Wireshark-commits] master 04df349: ModelHelperTreeItem: Rename appendChild -> p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 11 Feb 2018 16:56:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=04df34909f02013c36bc1e9ab33a52b34f374f80
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

04df349 by Michael Mann (mmann78@xxxxxxxxxxxx):

    ModelHelperTreeItem: Rename appendChild -> prependChild
    
    The function was actually calling QList<QVariant>.prepend underneath
    and some users of the class may need "append" to mean "append".
    prepend() is faster, but current users are sorting all lists anyway.
    
    Change-Id: I65cb02f4a2d1960cc2c49034963b191156789cc9
    Reviewed-on: https://code.wireshark.org/review/25730
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e438cf2   ieee80211: Fix reserved bit positions 18 & 19 when HE Support not set.
    adds  04df349   ModelHelperTreeItem: Rename appendChild -> prependChild


Summary of changes:
 ui/qt/models/dissector_tables_model.cpp    | 24 ++++++++++++------------
 ui/qt/models/enabled_protocols_model.cpp   |  4 ++--
 ui/qt/models/pref_models.cpp               | 20 ++++++++++----------
 ui/qt/models/supported_protocols_model.cpp |  4 ++--
 ui/qt/models/tree_model_helpers.h          |  2 +-
 5 files changed, 27 insertions(+), 27 deletions(-)