Wireshark-commits: [Wireshark-commits] master 60c5ec6: CIP Safety: Add decode options for I/O Paylo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 08 Feb 2018 23:40:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=60c5ec67f81393d979534c47a069c154277e477b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

60c5ec6 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP Safety: Add decode options for I/O Payloads
    
    1. Add Decode Options for 4 Safety I/O types. Previously, you could only decode as "CIP Safety", which only showed as a generic data block (because all important things for parsing are in the FwdOpen).
    2. Change some timestamp display formatting to match other related timestamp fields (now all Dec)
    3. Don't create connections for Null Forward Opens.
    
    Change-Id: Ia1031b3887739a864a453b9e566ebe6f29fa5b8b
    Reviewed-on: https://code.wireshark.org/review/25664
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  41812f2   QUIC: Add initial draft-09 support
    adds  60c5ec6   CIP Safety: Add decode options for I/O Payloads


Summary of changes:
 epan/dissectors/packet-cipsafety.c | 109 +++++++++++++++++++++++++++++++++++--
 epan/dissectors/packet-cipsafety.h |   1 +
 epan/dissectors/packet-enip.c      |   7 +++
 3 files changed, 113 insertions(+), 4 deletions(-)