Wireshark-commits: [Wireshark-commits] master 3ec8338: BACapp: Fix a loop check.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 06 Feb 2018 07:19:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ec83384977a6711e6c43906bf6118187be0bdde
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3ec8338 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    BACapp: Fix a loop check.
    
    Fix an offset check in a nested loop. Make our offset checks more
    paranoid.
    
    Bug: 14387
    Change-Id: I2890b27731ec293a3cb08dcfdf7a18aef808ad31
    Reviewed-on: https://code.wireshark.org/review/25622
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  dcfc574   IPMI: Add NULL pointer checks.
    adds  3ec8338   BACapp: Fix a loop check.


Summary of changes:
 epan/dissectors/packet-bacapp.c | 213 ++++++++++++++++++++--------------------
 1 file changed, 107 insertions(+), 106 deletions(-)