Wireshark · Wireshark-commits: [Wireshark-commits] master 1d999de: Qt: Update recent status via a non-blocking connection.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d999dea5c441131abfcfd8464f766f649f9a10f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1d999de by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Update recent status via a non-blocking connection.
    
    Connect our recent file status signal using a Qt::QueuedConnection
    instead of a Qt::BlockingQueuedConnection. As described at
    https://woboq.com/blog/how-qt-signals-slots-work-part3-queuedconnection.html,
    QueuedConnection makes a copy of the argument list while
    BlockingQueuedConnection passess the list directly.
    
    This fixes what appears to be a false positive reported by
    ThreadSanitizer. Cross-thread signals are protected by a QMutex, but
    qmutex_mac.cpp in the Qt5 sources uses a Mach semaphore. The
    ThreadSanitizer manual says it supports pthread mutexes and compiler
    atomic operations but doesn't mention Mach semaphores.
    
    Change-Id: Icb8a63d7d0bdfe985ab8274757043ef45ae4bcde
    Reviewed-on: https://code.wireshark.org/review/25576
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  90b3e72   Delete an out-of-date comment.
    adds  1d999de   Qt: Update recent status via a non-blocking connection.


Summary of changes:
 ui/qt/recent_file_status.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)