Wireshark · Wireshark-commits: [Wireshark-commits] master bb2680d: Don't put knowledge about the "is this pcapng" test in the block

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb2680d9b45275b6c9ada4c55cb0678a8e79b95a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bb2680d by Guy Harris (guy@xxxxxxxxxxxx):

    Don't put knowledge about the "is this pcapng" test in the block-reading code.
    
    Have pcapng_read_section_header_block(),
    pcapng_read_section_header_block(), and pcapng_read_block() just return
    errors when they get errors or get a non-SHB block; let pcap_open() turn
    EOF, short read, and "bad file" into "not a pcapng file" rather than
    "read error".
    
    Change-Id: If018d21ffe3de3fe7eb1f8f2973f80f685c89274
    Reviewed-on: https://code.wireshark.org/review/25601
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d447467   MQ: use real string length when calling strip_trailing_blanks()
    adds  bb2680d   Don't put knowledge about the "is this pcapng" test in the block-reading code.


Summary of changes:
 wiretap/pcapng.c | 63 ++++++++++++++++++--------------------------------------
 1 file changed, 20 insertions(+), 43 deletions(-)