Wireshark-commits: [Wireshark-commits] master 0c781ee: Disallow registration of some block type val
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 04 Feb 2018 00:42:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0c781eeef7a5322de2e96bb77b1029db35b4b2bc
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0c781ee by Guy Harris (guy@xxxxxxxxxxxx):

    Disallow registration of some block type values for plugins.
    
    Don't allow overriding of the block types we support in libwiretap - it
    won't work anyway, as we check for those types first, and only look for
    plugins for types we don't support.
    
    Don't allow registering for any of the reserved types; if you aren't
    going to use a local type, you have to get your type registered.
    
    We *do* allow registering plugins for types that are registered but that
    we don't support natively.
    
    Change-Id: I2046d297b0503d3a77c83166b07ca226c0b18e82
    Reviewed-on: https://code.wireshark.org/review/25583
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3d574a4   mqtt: Put msgid and topic in Info column
    adds  0c781ee   Disallow registration of some block type values for plugins.


Summary of changes:
 wiretap/pcapng.c        | 54 +++++++++++++++++++++++++++++++++++++++++++++++++
 wiretap/pcapng_module.h | 28 ++++++++++++++++---------
 2 files changed, 72 insertions(+), 10 deletions(-)