Wireshark-commits: [Wireshark-commits] master 2fecc96: dmp: fix memleaks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 03 Feb 2018 17:40:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2fecc9686864a7ef346220825eecbba1c3304987
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2fecc96 by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    dmp: fix memleaks
    
    dmp_long_id_hash_table is wmem_map autoreset on file scope.
    Don't put there g_strdup() data.
    
    Valgrind log:
    ==15134== 8 bytes in 2 blocks are definitely lost in loss record 3,988 of 49,961
    ==15134==    at 0x4C29C4F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==15134==    by 0xA94E405: g_malloc (gmem.c:97)
    ==15134==    by 0xA966C4E: g_strdup (gstrfuncs.c:356)
    ==15134==    by 0x6CFC301: dissect_mts_identifier (packet-dmp.c:2684)
    ==15134==    by 0x6D01A8F: dissect_dmp_envelope (packet-dmp.c:2935)
    ==15134==    by 0x6D01A8F: dissect_dmp (packet-dmp.c:3909)
    
    Found by oss-fuzz.
    
    Change-Id: I7c3896a9b64c25035fbe8b4ef6130cd693a515db
    Reviewed-on: https://code.wireshark.org/review/25575
    Petri-Dish: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  2d8606b   CIP Motion: Support Format Revision 3
    adds  2fecc96   dmp: fix memleaks


Summary of changes:
 epan/dissectors/packet-dmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)