Wireshark-commits: [Wireshark-commits] master f244742: epl: fix map.title memleak.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 02 Feb 2018 20:31:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f244742b46af8ec402761dee9240e25c2856cb77
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f244742 by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    epl: fix map.title memleak.
    
    Valgrind report:
    ==642== 14 bytes in 1 blocks are definitely lost in loss record 5,705 of 49,814
    ==642==    by 0xA966DCC: g_strdup_vprintf (gstrfuncs.c:507)
    ==642==    by 0xA966E88: g_strdup_printf (gstrfuncs.c:533)
    ==642==    by 0x6D523F4: dissect_object_mapping (packet-epl.c:4216)
    ==642==    by 0x6D56394: dissect_epl_sdo_command (packet-epl.c:3862)
    ==642==    by 0x6D56394: dissect_epl_asnd_sdo (packet-epl.c:3572)
    ==642==    by 0x6D59BC5: dissect_epl_asnd (packet-epl.c:3053)
    ==642==    by 0x6D59BC5: dissect_eplpdu.part.21 (packet-epl.c:2627)
    
    Found by oss-fuzz/5907.
    
    Change-Id: I6f4d2cea761581260af396c848ab1fded5641b44
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5907
    Reviewed-on: https://code.wireshark.org/review/25573
    Petri-Dish: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  d8565d8   Qt: Keep auto-scroll when starting a new capture
    adds  f244742   epl: fix map.title memleak.


Summary of changes:
 epan/dissectors/packet-epl.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)