Wireshark-commits: [Wireshark-commits] master dc86a28: SoupBinTCP: Remove try_conversation_dissecto
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 02 Feb 2018 01:50:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc86a285c1c7c23309728d587c3aaeeef3db6238
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dc86a28 by Michael Mann (mmann78@xxxxxxxxxxxx):

    SoupBinTCP: Remove try_conversation_dissector call
    
    As stated in the #if 0ed out comments, It's not valid for a
    soupbintcp subdissector to call conversation_set_dissector(), so
    it shouldn't call try_conversation_dissector.  Just remove the
    call entirely so it doesn't look like the removal is temporary.
    
    Change-Id: I68d9b72360b52002692c369d7b202a8a215c0a96
    Reviewed-on: https://code.wireshark.org/review/25555
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8bf837e   Qt: Always update splash screen on action change
    adds  dc86a28   SoupBinTCP: Remove try_conversation_dissector call


Summary of changes:
 epan/dissectors/packet-soupbintcp.c | 16 ----------------
 1 file changed, 16 deletions(-)