Wireshark · Wireshark-commits: [Wireshark-commits] master 0c7bbc7: Qt: Avoid a potentially large memdup.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0c7bbc75364ce21e6e911c93da748abf854999b1
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0c7bbc7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Avoid a potentially large memdup.
    
    Use QByteArray::fromRawData + tvb_get_ptr to create our ByteViewText
    data instead of tvb_memdup. If our tvb lifetime is shorter than our
    ByteViewText lifetime then that's a bug.
    
    Change-Id: Iede275578a1493b8658308e0778f7f0799d6c6cd
    Reviewed-on: https://code.wireshark.org/review/25534
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b14e32c   New dissector Session Multiplex Protocol SMP
    adds  0c7bbc7   Qt: Avoid a potentially large memdup.


Summary of changes:
 ui/qt/byte_view_tab.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)