Wireshark-commits: [Wireshark-commits] master 47e1798: Qt: Byte view and proto tree fixes.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 31 Jan 2018 04:54:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=47e1798762478ae19354297e5a95d46487cafd42
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

47e1798 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Byte view and proto tree fixes.
    
    Select our byte field only when we enter marked / locked mode.
    
    Emit fieldSelected from autoScrollTo so that we always set the marked
    protocol.
    
    Don't clobber the current index in saveSelectedField.
    
    Change-Id: I967b20608f991a5f3e6a0979b1f702f874ce27b4
    Reviewed-on: https://code.wireshark.org/review/25521
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  55e74ba   Qt: Write recent before applying profile changes
    adds  47e1798   Qt: Byte view and proto tree fixes.


Summary of changes:
 ui/qt/proto_tree.cpp             | 65 ++++++++++++++--------------------------
 ui/qt/widgets/byte_view_text.cpp |  6 ++--
 2 files changed, 26 insertions(+), 45 deletions(-)