Wireshark-commits: [Wireshark-commits] master-2.2 4ca3155: packet-icmp.c: Remove tree check that pr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 13 Apr 2017 02:46:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ca3155b7d6fbf5f05607ef454209a3f07096685
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

4ca3155 by Michael Mann (mmann78@xxxxxxxxxxxx):

    packet-icmp.c: Remove tree check that prevents expert info
    
    proto_tree_add_checksum uses expert info and shouldn't be
    "NULL tree protected"
    
    Change-Id: If8a367c2be69252e9c6613329b7f78ad7e1e34eb
    Ping-Bug: 13586
    Reviewed-on: https://code.wireshark.org/review/21012
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 6b30fe1ce5014ec332cf8c2f483f9f1c519e0167)
    Reviewed-on: https://code.wireshark.org/review/21071
    

Actions performed:

    from  d05983e   packet-epl.c: Fix bigger-than-actual offset being reported
    adds  4ca3155   packet-icmp.c: Remove tree check that prevents expert info


Summary of changes:
 epan/dissectors/packet-icmp.c |    4 ----
 1 file changed, 4 deletions(-)