Wireshark · Wireshark-commits: [Wireshark-commits] master 9769e8a: Use proto_get_finfo_ptr_array() rather than proto_find_finfo().

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9769e8af992ef1585492884c794cc95ff9c38cca
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9769e8a by Guy Harris (guy@xxxxxxxxxxxx):

    Use proto_get_finfo_ptr_array() rather than proto_find_finfo().
    
    As the comments say, proto_find_finfo() is slower than
    proto_get_finfo_ptr_array(), as it has to scan the entire tree, and,
    given that we're priming the tree with the fields we need (which we
    *have* to do to *guarantee* that we'll get the fields we want;
    requesting that a protocol tree be constructed isn't sufficient, and
    asking for a "visible" protocol tree is overkill),
    proto_get_finfo_ptr_array() will work.
    
    Change-Id: Ic1e21105a0a89003a3cdd3d7a2e55ac287ddad5e
    Reviewed-on: https://code.wireshark.org/review/21068
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  37e45cc   Fix indentation.
    adds  9769e8a   Use proto_get_finfo_ptr_array() rather than proto_find_finfo().


Summary of changes:
 plugins/transum/extractors.c |   16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)