Wireshark-commits: [Wireshark-commits] master-2.0 bcf1015: ieee80211: fix "INVALID" label in Endpoi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Apr 2017 12:26:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bcf10157d567068ad9c93ac3832bdd778fcda98a
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

bcf1015 by Peter Wu (peter@xxxxxxxxxxxxx):

    ieee80211: fix "INVALID" label in Endpoints dialog
    
    Problem: the "Apply as filter" option in the Endpoints dialog creates
    the "INVALID==11:22:33:44:55:66" filter for IEEE 802.11 packets.
    
    Since dissect_ieee80211_common initialises the address "whdr->src" and
    "whdr->dst" fields using the "wlan_address_type" type, we have to do the
    same in "wlan_host_get_filter_type". While at it, remove the check for
    AT_ETHER since these will never match.
    
    Change-Id: I43f9298adfa406ea37a383187137e3e0c1f8733d
    Reviewed-on: https://code.wireshark.org/review/21015
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit ccdb9073cdf1eee198e383ac202cb370bb0af6ce)
    Reviewed-on: https://code.wireshark.org/review/21044
    

Actions performed:

    from  604d1b6   Qt: mark bool and enum prefs as changed when modified via the menu
    adds  bcf1015   ieee80211: fix "INVALID" label in Endpoints dialog


Summary of changes:
 epan/dissectors/packet-ieee80211.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)